payload variant to omit unused binders#24
Open
MdSadiqMd wants to merge 1 commit intohyperpush-org:mainfrom
Open
payload variant to omit unused binders#24MdSadiqMd wants to merge 1 commit intohyperpush-org:mainfrom
MdSadiqMd wants to merge 1 commit intohyperpush-org:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #22
Summary
Allow payload-bearing constructor patterns to omit unused binders in pattern matching. Users can now write
Ok -> ...andErr -> ...instead of requiringOk(_) -> ...andErr(_) -> ...when the payload is intentionally ignored.Changes:
mesh-typeck/src/infer.rs): Treat bare payload-bearing constructors as having wildcard arguments for all fields; recognize uppercase identifiers with function types as constructors and return their result typemesh-codegen/src/mir/lower.rs): GenerateMirPattern::Constructorwith wildcard patterns for all variant fields when no explicit binder is providedOk/Err,Some/None, and mixed bare/explicit formsThis eliminates repetitive placeholder noise in Result/Option-heavy code while maintaining exhaustiveness checking and type safety.
Verification